Re: [PATCH 3/3] mount-swapon: clean up gcc warnings

[Nix <nix@xxxxxxxxxxxxx>]

On 3 Oct 2007, Karel Zak spake thusly:

> On Wed, Oct 03, 2007 at 02:15:32PM -0700, Randy Dunlap wrote:
>>  	/* skip the first line */
>> -	fgets(line, sizeof(line), swaps);
>> +	if (!fgets(line, sizeof(line), swaps))
>> +		fprintf (stderr, _("%s: fgets of \"%s\" is empty\n"),
>> +			progname, PROC_SWAPS);
>
>  I think end-users know nothing about fgets(), what about:
>
>  if (!fgets(line, sizeof(line), swaps))
>     fprintf (stderr, _("%s: %s: unexpectied file format\n"),
>             progname, PROC_SWAPS);
>     return;
>  }

It's completely pedantic of me, I know, but that should be `unexpected'.
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html