Re: [PATCH 1/3] mkfs.minix: clean up gcc warnings

Karel Zak <kzak@xxxxxxxxxx> · Tue, 2 Oct 2007 11:38:43 +0200

On Sat, Sep 29, 2007 at 01:11:29AM -0700, Randy Dunlap wrote:
>  	while (!feof(listfile)) {
> -		fscanf(listfile,"%ld\n", &blockno);
> +		if (fscanf(listfile,"%ld\n", &blockno) != 1) {
> +			printf(_("badblock number input error on line %d\n"), badblocks);

 printf(_("badblock number input error on line %d\n"), badblocks+1);

 I think 1, 2..N  is better than 0, 1..  :-)

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html