Re: Read errors on Flash Drive Transcend TS1GJF2A

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Fri, 12 Oct 2007, Dominique Dumont wrote:

> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
> 
> > Okay.  That narrows it down to a single patch, this one:
> >
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=03aba2f79594ca94d159c8bab454de9bcc385b76
> 
> There's a weird line in this patch:
> 
> -               if (scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
> +               if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL)
> 
> The '!!result' is a double negative.
> 
> This is corrected in linux 2.6.22:
> 
>         /* A number of bytes were successfully read.  If there
>          * are leftovers and there is some kind of error
>          * (result != 0), retry the rest.
>          */
>         if (scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
>                 return;

In fact it was corrected before 2.6.18-rc1 appeared, so it can't 
explain RTE's problem.

Alan Stern


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Linux-usb-users@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users