Re: [PATCH 11/16] iim: don't try to set ethaddr when NET is not selected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, May 17, 2012 at 05:46:13PM +0200, Eric Bénard wrote:
> an otther way to solve this would be to put the #ifdef CONFIG_NET
> around xxx__iim_register_fec_ethaddr in the board support but that's
> less generic.

Maybe better to provide a static inline function for
eth_register_ethaddr if !CONFIG_NET?

Sascha

> 
> Signed-off-by: Eric Bénard <eric@xxxxxxxxxx>
> ---
>  arch/arm/mach-imx/include/mach/iim.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/include/mach/iim.h b/arch/arm/mach-imx/include/mach/iim.h
> index b97c742..61d68e3 100644
> --- a/arch/arm/mach-imx/include/mach/iim.h
> +++ b/arch/arm/mach-imx/include/mach/iim.h
> @@ -66,7 +66,9 @@ static inline int imx51_iim_register_fec_ethaddr(void)
>  	if (ret != 6)
>  		return -EINVAL;
>  
> +#ifdef CONFIG_NET
>  	eth_register_ethaddr(0, buf);
> +#endif
>  
>  	return 0;
>  }
> @@ -85,7 +87,9 @@ static inline int imx25_iim_register_fec_ethaddr(void)
>  	if (ret != 6)
>  		return -EINVAL;
>  
> +#ifdef CONFIG_NET
>  	eth_register_ethaddr(0, buf);
> +#endif
>  
>  	return 0;
>  }
> -- 
> 1.7.7.6
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux