Re: [target:for-linus 1/1] drivers/vhost/tcm_vhost.c:537:23-29: ERROR: allocation function on line 533 returns NULL not ERR_PTR on failure

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Sat, 2012-07-28 at 18:20 +0800, Fengguang Wu wrote:
> Hi Nicholas,
> 
> There are new coccinelle warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-linus
> head:   fd682824bcdab8cbb3d078f9f59ba531e3e41484
> commit: fd682824bcdab8cbb3d078f9f59ba531e3e41484 [1/1] tcm_vhost: Initial merge for vhost level target fabric driver
> 
> All coccinelle warnings:
> 
> drivers/vhost/tcm_vhost.c:537:23-29: ERROR: allocation function on line 533 returns NULL not ERR_PTR on failure
> 
> vim +537 drivers/vhost/tcm_vhost.c
>    534		if (!sg)
>    535			return -ENOMEM;
>    536		pr_debug("%s sg %p sgl_count %u is_err %ld\n", __func__,
>  > 537		       sg, sgl_count, IS_ERR(sg));
>    538		sg_init_table(sg, sgl_count);
>    539	
>    540		tv_cmd->tvc_sgl = sg;
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Centre
> Fengguang Wu <wfg@xxxxxxxxxxxxxxx>                     Intel Corporation

I've included this fix into a post-merge series for tcm-vhost.

Also FYI, I changed this patch slightly to use %d as it was still
generating a format spec warning.. 

Thanks WU!

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html