Re: [PATCH] target: remove the execute list

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Sun, 2012-05-20 at 14:34 -0400, Christoph Hellwig wrote:
> Since "target: Drop se_device TCQ queue_depth usage from I/O path" we always
> submit all commands (or back then, tasks) from __transport_execute_tasks.
> 
> That means the the execute list has lots its purpose, as we can simply
> submit the commands that are restarted in transport_complete_task_attr
> directly while we walk the list.  In fact doing so also solves a race
> in the way it currently walks to delayed_cmd_list as well.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> ---
>  drivers/target/target_core_internal.h  |    1 
>  drivers/target/target_core_tmr.c       |    3 
>  drivers/target/target_core_transport.c |  332 +++++++++------------------------
>  include/target/target_core_base.h      |    3 
>  4 files changed, 98 insertions(+), 241 deletions(-)

Applied to 3.6-queue.

Nice work on resolving the long standing delayed_cmd_list race btw.  ;)

Thanks Christoph!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html