Re: [patch 2/2] target: usb-gadget: cleanup duplicate initialization

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Tue, 2012-04-17 at 09:32 +0300, Dan Carpenter wrote:
> Sparse points out that we initialize .bAlternateSetting twice.  But
> fortunately USB_G_ALT_INT_BBB is zero so we initialize it to the same
> value both times.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/target/usb-gadget/usb_gadget.c b/drivers/target/usb-gadget/usb_gadget.c
> index ba62bef..78aa37e 100644
> --- a/drivers/target/usb-gadget/usb_gadget.c
> +++ b/drivers/target/usb-gadget/usb_gadget.c
> @@ -1977,7 +1977,6 @@ static void usbg_deregister_configfs(void)
>  static struct usb_interface_descriptor bot_intf_desc = {
>  	.bLength =              sizeof(bot_intf_desc),
>  	.bDescriptorType =      USB_DT_INTERFACE,
> -	.bAlternateSetting =	0,
>  	.bNumEndpoints =        2,
>  	.bAlternateSetting =	USB_G_ALT_INT_BBB,
>  	.bInterfaceClass =      USB_CLASS_MASS_STORAGE,
> --

Applied.  Thanks DanC!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html