Re: [PATCH 3/3] tcm_vhost: Convert to use mainline virtio_scsi.h

[Zhi Yong Wu <zwu.kernel@xxxxxxxxx>]

On Wed, Apr 11, 2012 at 2:40 PM, Nicholas A. Bellinger
<nab@xxxxxxxxxxxxxxx> wrote:
> On Tue, 2012-04-10 at 10:40 +0100, Stefan Hajnoczi wrote:
>> On Sun, Apr 08, 2012 at 06:30:55AM +0000, Nicholas A. Bellinger wrote:
>> > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
>> >
>> > This patch converts tcm_vhost in lio-core.git to use mainline
>> > virtio_scsi.h defines from v3.4-rc2.  This includes:
>> >
>> > *) Rename virtio_scsi_cmd_header -> virtio_scsi_cmd_req
>> > *) Rename virtio_scsi_footer -> virtio_scsi_cmd_resp
>> > *) Convert vhost_scsi_handle_vq() use scsilun_to_int() from v_req->lun[8]
>> >
>> > So for this has been compile tested only, but the changes look
>> > reasonably straight-forward.  Please have a look Stefan & Co..
>>
>> The mainline drivers/scsi/virtio_scsi.c implements a newer virtio-scsi
>> device model than tcm_vhost.  Therefore mainline virtio_scsi.ko and
>> tcm_vhost.ko are not compatible.
>>
>> This is okay, we've known about the breakage and it's time to update
>> tcm_vhost to support the virtio-scsi device specification.
>>
>> Please go ahead an apply this.  Further patches will be needed to make
>> tcm_vhost work again but this is expected.
>>
>
> Hi Stefan,
>
> <nod>, I figured this was the case..
>
> Thanks for the feedback, and I'm looking forward to seeing tcm_vhost
> running virtio-scsi packets again soon on -rc2.  8-)
I am debugging this, pls give me some time.:)
>
> Thanks!
>
> --nab
>
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Regards,

Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html