Re: [PATCH] target: Fix sense code for unsupported SERVICE ACTION IN

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Wed, 2012-03-14 at 10:40 -0700, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> 
> If we don't handle a given service action, we're supposed to return
> INVALID FIELD IN CDB, since we do handle the SERVICE ACTION IN opcode.
> 
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
>  drivers/target/target_core_transport.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index cfdfb80..e252925 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -2948,7 +2948,7 @@ static int transport_generic_cmd_sequencer(
>  
>  			pr_err("Unsupported SA: 0x%02x\n",
>  				cmd->t_task_cdb[1] & 0x1f);
> -			goto out_unsupported_cdb;
> +			goto out_invalid_cdb_field;
>  		}
>  		/*FALLTHROUGH*/
>  	case ACCESS_CONTROL_IN:

Appled.  Thanks again Roland!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html