Re: [PATCH] target: Remove hack to make READ CAPACITY(10) lie if thin provisioning is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, 2012-03-14 at 10:12 -0700, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> 
> Remove the hack that has READ CAPACITY(10) return 0xFFFFFFFF as the
> number of sectors when thin provisioning is enabled.  This is supposed
> to trigger the initiator to use READ CAPACITY(16) in this case so that
> it finds out about thin provisioning.  But an initiator that cares about
> thin provisioning is going to ask anyway, and an initiator that doesn't
> know about READ CAPACITY(16) is going to get the wrong capacity.  So
> just have READ CAPACITY(10) return the size it's supposed to.
> 
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
>  drivers/target/target_core_cdb.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
> index 41ca2d4..30a6770 100644
> --- a/drivers/target/target_core_cdb.c
> +++ b/drivers/target/target_core_cdb.c
> @@ -694,11 +694,6 @@ int target_emulate_readcapacity(struct se_task *task)
>  	buf[5] = (dev->se_sub_dev->se_dev_attrib.block_size >> 16) & 0xff;
>  	buf[6] = (dev->se_sub_dev->se_dev_attrib.block_size >> 8) & 0xff;
>  	buf[7] = dev->se_sub_dev->se_dev_attrib.block_size & 0xff;
> -	/*
> -	 * Set max 32-bit blocks to signal SERVICE ACTION READ_CAPACITY_16
> -	*/
> -	if (dev->se_sub_dev->se_dev_attrib.emulate_tpu || dev->se_sub_dev->se_dev_attrib.emulate_tpws)
> -		put_unaligned_be32(0xFFFFFFFF, &buf[0]);
>  
>  	transport_kunmap_data_sg(cmd);
>  

Applied.  Thanks Roland!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux