[PATCH 0/2] target: Fix CRH=1 and iscsi-target reservation conflict handling

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>

These two patches address breakage related to reservation handling recently
reported by Martin Svec using v3.2 and newer iscsi-target code from lio-core
and mainline trees.

The first patch is related to compatible reservation handling (CRH=1) in target
core, that was allowing a new legacy reservation to be created by RESERVE when
an active SPC-3 persistent reservation already exists for the same initiator
port.  It also was not returning reservation conflict correctly for these
special CRH=1 cases.

The second patch is specific to iscsi-target reservation conflict response
handling, where iscsi-target was causing reservation conflicts to be ignored
due to a bogus errno specific check in iscsi-target code.  This was causing
non reserved initiator ports write access to LUNs, and causing data corruption
with multiple writers + iscsi-target + legacy reservations.

Because patch #2 involves data corruption with multiple clients + reservation
access, please strongly consider upgrading all >= v3.2 based iscsi-target
installations to include this patca.

I'll be adding this to a target-pending.git/3.3-urgent branch ASAP with a
CC to 3.2 stable.

--nab

Nicholas Bellinger (2):
  target: Fix compatible reservation handling (CRH=1) with legacy
    RESERVE/RELEASE
  iscsi-target: Fix reservation conflict -EBUSY response handling bug

 drivers/target/iscsi/iscsi_target.c    |    2 +-
 drivers/target/target_core_pr.c        |   34 ++++++++++++++++++++-----------
 drivers/target/target_core_transport.c |    1 +
 3 files changed, 24 insertions(+), 13 deletions(-)

-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html