Re: [PATCH 0/5] target: Add se_session->sess_kref + convert iscsi/qla2xxx fabrics

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Tue, 2012-02-28 at 10:58 -0500, Jörn Engel wrote:
> On Tue, 28 February 2012 00:56:15 -0800, Nicholas A. Bellinger wrote:
> > 
> > The sessions associated with the se_node_acl->acl_group are required to
> > be shutdown because they may be referencing struct se_node_acl memory,
> > and the configfs rmdir operation for se_node_acl->acl_group or any
> > group) is not allowed to fail.
> 
> Sounds like we can either add reverse mapping from the configfs
> structure to all referencing sessions and rip out the references or go
> through an indirection and simple mark the configfs parts as gone in
> the indirection.

We expect to have access to se_node_acl while a se_session is active.
Ripping out references of se_node_acl from a live se_session is not the
right thing to do here..

> I see no reason to tear down and recreate sessions
> just to fulfill the configfs requirement.
> 

Sure there is.  With most fabrics (including iscsi-target) when a
NodeACL is removed it's effectively saying "I don't want this initiator
to have access anymore to this endpoint".  This involves stopping the
active session and preventing a new session from being created..

tcm_qla2xxx is special because we still allow demo-mode in order to
prevent issues with FC clients exploding when the fabric login request
is rejected.

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html