Re: [PATCH 0/5] target: Add se_session->sess_kref + convert iscsi/qla2xxx fabrics

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Tue, 2012-02-28 at 00:18 -0800, Roland Dreier wrote:
> On Mon, Feb 27, 2012 at 11:51 PM, Nicholas A. Bellinger
> <nab@xxxxxxxxxxxxxxx> wrote:
> > tcm_fc currently uses it's own session referencing that can be converted
> > to se_sess->sess_kref usage without too much effort.
> 
> ...although current code looks similarly busted:
> 
> /*
>  * Remove session and send PRLO.
>  * This is called when the ACL is being deleted or queue depth is changing.
>  */
> void ft_sess_close(struct se_session *se_sess)
> 
> ... so we have good intentions to log out initiator as the
> comment says, but then the actual code ends with:
> 
>         ft_sess_put(sess);
>         /* XXX Send LOGO or PRLO */

A fabric logout sequence should start happening in
TFO->shutdown_session() before ft_sess_close() gets called here.

Anyways, I've not looked at how tcm_fc(fcoe) or tcm_qla2xxx could
implement explict logout just yet..

--nab







--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html