Re: [PATCH 0/5] target: Add se_session->sess_kref + convert iscsi/qla2xxx fabrics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Feb 27, 2012 at 11:51 PM, Nicholas A. Bellinger
<nab@xxxxxxxxxxxxxxx> wrote:
> I'm not sure what you mean here wrt to tcm_loop, as sessions are
> generated from a configfs attribute and mapped 1:1 with target
> endpoints.

I meant make the tcm_qla2xxx implementation of shutdown_session
and close_session closer to tcm_loop, which has:

static int tcm_loop_shutdown_session(struct se_session *se_sess)
{
        return 0;
}

static void tcm_loop_close_session(struct se_session *se_sess)
{
        return;
};

When we remove ACLs in tcm_qla2xxx, we don't actually
kick out any initiators that may be logged into our FC ports,
so it's not clear to me why we try to shut down sessions.

The conditions that are true in qla_tgt_fc_port_added() are
true no matter what ACLs we have so it doesn't seem like
a good idea to make our session database out of sync with
the FW state when removing ACLs.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux