Re: [PATCH] target: Fix off-by-seven in target_report_luns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Feb 16, 2012 at 8:14 AM, Jörn Engel <joern@xxxxxxxxx> wrote:
> cdb_offset is always equal to offset - 8, so remove that one.  More
> importantly, the existing code only worked correct if
> se_cmd->data_length is a multiple of 8.  Pass in a length of, say, 9 and
> we will happily overwrite 7 bytes of "unallocated" memory.

This is fine for now but I think neither this nor the old code complies
100% with the scsi spec.  If I understand correctly, if we pass in an
allocation length of 9, we should return the first byte of the first LUN.

Maybe an 8 byte temp buffer + a memcpy to handle this partial case?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photos]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

Add to Google Powered by Linux