Re: [PATCH 0/6] a few CDB emulation cleanups

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Thu, 2011-11-03 at 17:50 -0400, Christoph Hellwig wrote:
> This series gets us about half-way to add a command_sequencer callback
> to the backend and allow to handle different command sets.  I think it's
> a good enough cleanup on its own, so it might be worth putting it in now.
> --

A nice cleanup.  Just fixed one minor bit in patch #6 for passthrough=1
SERVICE_ACTION_IN default handling that was originally rejected for both
cases.  Overall I think it looks very reasonable for merge.

One of the next items is fix up the sense_reason CDB specific return
value handling that needs some attention in a few areas with
transport_generic_new_cmd() and cmd->transport_error_status +
transport_generic_request_failure() returns.  We should be setting
cmd->scsi_sense_reason codes directly in CDB specific failure cases
using tcm_sense_reason_table in functions called below
transport_generic_new_cmd().  Ditto for ->execute_task() so we can
eventually drop PYX_TRANSPORT_* return codes completely from
target_core_transport.h.

I'll get the first part addressed soon, but will probably being a -rc2
item as the window closes in the next days.  The mainline PULL for
what's currently in target-pending.git for-next/for-next-merge needs to
go out today or tomorrow for round 2 updates (including this series) and
initial ib_srpt merge, so please let me know if you have anything else
for -rc1.

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html