Re: [Spice-commits] spice/enums.h

[Alon Levy <alevy@xxxxxxxxxx>]

On Mon, Jul 16, 2012 at 02:47:35PM +0200, Marc-André Lureau wrote:
> On Mon, Jul 16, 2012 at 2:45 PM, Alon Levy <alevy@xxxxxxxxxx> wrote:
> > On Mon, Jul 16, 2012 at 02:26:20PM +0200, Marc-André Lureau wrote:
> >> On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy <alon@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >> >    SPICE_MSGC_SMARTCARD_DATA = 101,
> >> > +    SPICE_MSGC_SMARTCARD_HEADER = 101,
> >> > +    SPICE_MSGC_SMARTCARD_ERROR = 101,
> >> > +    SPICE_MSGC_SMARTCARD_ATR = 101,
> >> > +    SPICE_MSGC_SMARTCARD_READER_ADD = 101,
> >>
> >> Is this normal?
> >
> > It was added by recent changes to spice-common, yes.
> 
> I got that, but all enums have value 101, really?
[could you please keep me in cc/to?]

Yes, it's ugly, but it's correct. Smartcard messages type is in the
payload of the spice message, the spice message type is not reused.
Since spice.proto grew the inner smartcard message definitions
(header/error/atr/reader_add) in the smartcard channel definition
(spice.proto) these values were set explicitly. They are not ever used
of course, only the first (already there) SPICE_MSGC_SMARTCARD_DATA is
used.

> 
> -- 
> Marc-André Lureau
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel