Re: [PATCH] sparc64: Use node local allocations for IRQ stacks.

[Sam Ravnborg <sam@xxxxxxxxxxxx>]

On Fri, Apr 27, 2012 at 01:34:07PM -0400, David Miller wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Date: Fri, 27 Apr 2012 19:27:50 +0200
> 
> > This assignment looks redundant. I cannot see any uses of max_mapnr
> > in the kernel (which is relevant for sparc64).
> 
> pfn_valid() via asm-generic/page.h

asm-generic/page.h is for non-MMU architectures.
It includes:
#ifdef CONFIG_MMU
#error need to prove a real asm/page.h
#endif

> 
> > Knowing that sparc64 just got converted to NO_BOOTMEM it
> > hurts my eyes to see memblock_alloc() be replaced
> > by __alloc_bootmem_node().
> 
> Since the stack allocations happen now (for the sake of setting
> up the NUMA mappings) after bootmem init, it's prudent to use
> the alloc_bootmem interfaces.

It was my understanding that everything provided by mm/nobootmem.c
is wrappers provided for backward compatibility with the old
bootmem based early allocator.
And that we later would make this file optional when.

But I seems to be wrong here.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html