Re: [PATCH] net: filter: Just In Time compiler for sparc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


David Miller wrote:

Signed-off-by: David S. Miller<davem@xxxxxxxxxxxxx>
---

I think I'll commit this to net-next so it's easier to track
any BPF changes we make there.

I hate to nitpick; see below.

+	bl	bpf_slow_path_word_neg
+	 nop
+	.globl	bpf_jit_load_word_positive_offset
+bpf_jit_load_word_positive_offset:
+	sub	r_HEADLEN, r_OFF, r_TMP
+	cmp	r_TMP, 3
+	ble	bpf_slow_path_word
+	 add	r_SKB_DATA, r_OFF, r_TMP
+	andcc	r_TMP, 3, %g0
+	bne	load_word_unaligned
+	 nop
+	retl
+	 ld	[r_SKB_DATA + r_OFF], r_A

There is inconsistent spacing in multiple places; a few examples shown above.

KR, Jan
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux MIPS Home]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite News]     [MIPS Architecture]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux