Re: silo trouble with ext3

[Jurij Smakov <jurij@xxxxxxxxx>]

On Tue, Feb 21, 2012 at 08:27:33PM -0500, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 21 Feb 2012 18:33:10 -0500 (EST)
> 
> > From: David Miller <davem@xxxxxxxxxxxxx>
> > Date: Tue, 21 Feb 2012 18:10:07 -0500 (EST)
> > 
> >> For example, I just found a bug with symlink handling in path
> >> traversal fixed by the following patch.  So if there are symlinks
> >> involved in Meelis's setup that would be the cause rather than not
> >> specifically using ext2 for the boot partition.
> >> 
> >> --------------------
> >> ext2: Fix symlink being overwritten.
> > 
> > Ignore me, there is no bug.  All callers specifically use a special
> > on-stack inode buffer to avoid this problem.
> 
> Ok, while waiting for the debug dump from Meelis I think I found the
> problem.
> 
> With my test harness I reproduced a case similar to what Meelis saw
> but it has nothing to do with ext3'ness or anything like that.
> 
> The block group descriptors were having their location miscalculated.
> It only worked for the first block of group descriptors.
> 
> So if an inode is outside of the first several block groups, things
> don't work.  I guess for most /boot partitions, which are relatively
> small, most if not all of the files fit into the working range.
> 
> Jurij, can you possibly build a test package for Meelis to see if this
> fixes the reported bug?

Sure, a new package with this patch included is available at
http://www.wooyd.org/silo/

Best regards,
-- 
Jurij Smakov                                           jurij@xxxxxxxxx
Key: http://www.wooyd.org/pgpkey/                      KeyID: C99E03CC
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html