Re: [PATCH][resending] SPARC32: forced setting of mode of SUN4M per-cpu timers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


> >>  +#ifdef CONFIG_SMP
> >>  + /* Timer-mode for every per-cpu timer (bit '0' is timer mode) */
> >>  + sbus_writel(0x00000000, &timers_global->timer_config);
> >>  +#endif
> >
> > Does this have to be SMP only - I think not.
> 
> There is no difference of which mode is used in case of UP. If it is timer mode, it doesn't tick because limit is 0. If it is counter mode, it doesn't tick too. And kernel doesn't touch per-cpu timer registers in other way, it has a deal with interrupts only.
> 
> Ok?

In that case just always set the mode.
We prefer minimal ifdefs in the code.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux MIPS Home]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite News]     [MIPS Architecture]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux