Re: [PATCH 4/4] kernel,debug: SPARC KGDB stub strcpy fix

[Konrad Eisele <konrad@xxxxxxxxxxx>]

David Miller wrote:
> From: Konrad Eisele <konrad@xxxxxxxxxxx>
> Date: Fri, 30 Sep 2011 15:47:30 +0200
> 
>> Works aroung the fact that strcpy in SPARC returns 0.
>>
>> Signed-off-by: Konrad Eisele <konrad@xxxxxxxxxxx>
> 
> Fix strcpy() on SPARC instead please.
> --
> To unsubscribe from this list: send the line "unsubscribe sparclinux" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
It is a gcc optimization. strcpy(p,"string") is converted to memcpy(p,7).
I could think of 2 ways:
- fix memcpy() so that it returns the dest-pointer instead of 0. (However
  there might be a reason that it returns 0 ...
- keep the "kernel,debug: SPARC KGDB stub strcpy fix" patch but change the
  summary of the patch to:
    Works aroung the fact that strcpy with a constant string is
    converted to memcpy by gcc and that  memcpy in SPARC returns 0.

I'll send the 2 possibilities as a reply in a moment.

-- Konrad

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html