Re: buffer overflow check bug

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

On Mon, Jun 18, 2012 at 01:04:07PM -0700, Josh Triplett wrote:
> On Mon, Jun 18, 2012 at 10:53:44PM +0300, Dan Carpenter wrote:
> > Gar...  I have no idea.  That seems like an issue in sparse.
> > 
> > Does anyone know why MOD_NORETURN gets set for:
> > extern void my_exit(const char*, ...) __attribute__ ((__noreturn__));
> > 
> > but not for:
> > extern __attribute__ ((__noreturn__)) void my_exit(const char*, ...);
> > 
> > GCC seems to accept both formats.
> 
> I wonder if the latter gets incorrectly parsed as though the attribute
> attached to "void" rather than "my_exit"?
> 

I put a:
	printf("%d %d token = %s\n", token->pos.line, token->pos.pos, token->ident->name);
in handle_attributes() and it only prints when the attribute is at
the end.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe smatch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html