Re: [PATCH 1/4] libsemanage -- fallback-user-level

[Russell Coker <russell@xxxxxxxxxxxx>]

On Tue, 27 Mar 2012, Laurent Bigonville <bigon@xxxxxxxxxx> wrote:
> I've no rational and no original author about this patch.

That would be mine.  Having magic numbers in the code is a bad idea, using a 
macro is better.

> 
> --- a/libsemanage/src/genhomedircon.c
> +++ b/libsemanage/src/genhomedircon.c
> @@ -863,7 +877,7 @@
>  			level = semanage_user_get_mlslevel(*u);
>  		} else {
>  			prefix = name;
> -			level = "s0";
> +			level = FALLBACK_USER_LEVEL;
>  		}
> 
>  		retval = getpwnam_r(name, &pwstorage, rbuf, rbuflen, &pwent);
> 
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx
> with the words "unsubscribe selinux" without quotes as the message.


-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.