Re: [PATCH 2/2] md:Rewrite the md_write_start().

[Dan Williams <dan.j.williams@xxxxxxxxx>]

On Sat, Jun 2, 2012 at 1:16 AM, majianpeng <majianpeng@xxxxxxxxx> wrote:
> Remove the judgement "bio_data_dir(bi) != WRITE" in md_write_start().Put
> it before call md_write_start.
>
> Signed-off-by: majianpeng <majianpeng@xxxxxxxxx>
> ---
>  drivers/md/md.c     |    4 +---
>  drivers/md/md.h     |    2 +-
>  drivers/md/raid1.c  |    4 ++--
>  drivers/md/raid10.c |    3 ++-
>  drivers/md/raid5.c  |    3 ++-
>  5 files changed, 8 insertions(+), 8 deletions(-)

If the deletions had outnumbered the insertions then maybe, but I
think just like kfree() allowing NULL pointers it's cleaner if the
caller need not worry.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html