Re: [patch] md/raid10: unlock on error path in raid10_start_reshape()

[NeilBrown <neilb@xxxxxxx>]

On Thu, 17 May 2012 09:49:11 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx>
wrote:

> We need to unlock and enable IRQs before returning here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index e8ed1d8..ba7290f 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -3918,6 +3918,7 @@ static int raid10_start_reshape(struct mddev *mddev)
>  	if (mddev->reshape_backwards) {
>  		sector_t size = raid10_size(mddev, 0, 0);
>  		if (size < mddev->array_sectors) {
> +			spin_unlock_irq(&conf->device_lock);
>  			printk(KERN_ERR "md/raid10:%s: array size must be reduce before number of disks\n",
>  			       mdname(mddev));
>  			return -EINVAL;

Hi Dan,
 thanks heaps for this!!
I've merged the change into the original patch with suitable attribution.
The result should get into tomorrows linux-next.

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature