Re: md/bitmap: move some fields of 'struct bitmap' into a 'storage' substruct.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Apr 23, 2012 at 10:10:49AM +1000, NeilBrown wrote:
> On Fri, 20 Apr 2012 16:13:36 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >   1210			if (test_and_clear_page_attr(bitmap, j,
> >   1211						     BITMAP_PAGE_NEEDWRITE)) {
> >   1212				write_page(bitmap, bitmap->storage.filemap[j], 0);
> >                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Renamed dereference.
> 
> There is a relationship between storage.filemap and storage.file_pages.
> If the later is 0, the former must be non-NULL.
> 
> This dereference only happens if file_pages > 0...  Maybe I should check
> file_pages up above so as not to confuse smatch??
> 

False positives are not really a problem.  I only look at new
warnings.  My dream is that someday Smatch will be able to figure
out the code flow as it is.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[ATA RAID]     [Linux SCSI Target Infrastructure]     [Managing RAID on Linux]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device-Mapper]     [Kernel]     [Linux Books]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Photos]     [Yosemite Photos]     [Yosemite News]     [AMD 64]     [Linux Networking]

Add to Google Powered by Linux