Re: [PATCH 4/8] md: analyze_sbs(): Fix potential NULL-pointer dereference.

[Neil Brown <neilb@xxxxxxx>]

On Tuesday March 25, maan@xxxxxxxxxxxxxxx wrote:
> If no device in the array contains a valid super block, "freshest"
> will be NULL, but we happily dereference that pointer in the subsequent
> call to validate_super().
> 
> Fix it by returning early in this case.
> 
> Signed-off-by: Andre Noll <maan@xxxxxxxxxxxxxxx>
> ---
>  drivers/md/md.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 7943df1..bf1499c 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2249,6 +2249,10 @@ static void analyze_sbs(mddev_t * mddev)
>  			kick_rdev_from_array(rdev);
>  		}
>  
> +	if (!freshest) {
> +		printk(KERN_ERR "md: no valid devices found\n");
> +		return;
> +	}
>  
>  	super_types[mddev->major_version].
>  		validate_super(mddev, freshest);

This shouldn't actually be possible.  But I've got to rush off just
now.  I'll have a deeper look later.

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html