Re: [patch] ideapad: uninitialized data in ideapad_acpi_add()

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

On Wed, Jun 20, 2012 at 08:23:13PM +0800, Ike Panhc wrote:
> Hi Dan,
> 
> # cat /sys/kernel/debug/ideapad/cfg
> cfg: 0xFFFF8800007DE140
>        ^^^^^^^^ the uninitialized bit
> 
> I see your point, perhaps unsigned int will be better then int?
> 

I don't know if this is a question or a resend request.

I just chose that base on the fact that we are reading an int from
ACPI in read_method_int(adevice->handle, "_CFG", &cfg).  Either way
we're going to run into integer conversion issues if we get passed
a large or negative int.

I can resend if you want, I don't have strong feelings on this.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html