Re: [PATCH] apple-gmux: Add suspend/resume support for the backlight

[David Woodhouse <dwmw2@xxxxxxxxxxxxx>]

On Thu, 2012-04-19 at 10:55 -0500, Seth Forshee wrote:
> --- a/drivers/platform/x86/apple-gmux.c
> +++ b/drivers/platform/x86/apple-gmux.c
> @@ -87,6 +87,9 @@ static int gmux_update_status(struct backlight_device *bd)
>         struct apple_gmux_data *gmux_data = bl_get_data(bd);
>         u32 brightness = bd->props.brightness;
>  
> +       if (bd->props.state & BL_CORE_SUSPENDED)
> +               brightness = 0;
> +
>         /*
>          * Older gmux versions require writing out lower bytes first then
>          * setting the upper byte to 0 to flush the values. Newer versions

Is this part necessary? It's about to be turned off *anyway*, and
turning it off sooner will achieve little other than to make it harder
to debug suspend failures, surely?

-- 
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature