Re: [PATCH 3/3 v3] asus-nb-wmi: move WAPF variable into quirks_entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Mar 19, 2012 at 10:46 AM, AceLan Kao <acelan.kao@xxxxxxxxxxxxx> wrote:
> Dear Corentin,
>
> 2012/3/19 Corentin Chary <corentin.chary@xxxxxxxxx>:
>> On Mon, Mar 19, 2012 at 7:33 AM, AceLan Kao <acelan.kao@xxxxxxxxxxxxx> wrote:
>>> Some models work better with different values of wapf, so move the
>>> variable into quriks_entry to make it more easy to give a specific
>>> value to different models.
>>>
>>> Signed-off-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
>>> ---
>>>  drivers/platform/x86/asus-nb-wmi.c |    2 +-
>>>  drivers/platform/x86/asus-wmi.c    |    4 ++--
>>>  drivers/platform/x86/asus-wmi.h    |    2 +-
>>>  drivers/platform/x86/eeepc-wmi.c   |    2 +-
>>>  4 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>>> index 396dafc..9dd7b93 100644
>>> --- a/drivers/platform/x86/asus-nb-wmi.c
>>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>>> @@ -53,7 +53,7 @@ MODULE_PARM_DESC(wapf, "WAPF value");
>>>
>>>  static void asus_nb_wmi_quirks(struct asus_wmi_driver *driver)
>>>  {
>>
>> Missing "driver->quirks = asus_unknown_quriks" (or similar). quirks is
>> NULL here, and the module will segfault (unfortunatly I tried without
>> reading the code and it did :p).
>
> So sorry about that, I'm not aware of the loading sequence of the
> asus-nb-wmi module,

Of course, always harder without the hardware :).

> I thought it can see drivers->quirks which assigned from eeepc-wmi module.
> If I allocate a new asus_unknown_quirks here, then it might be
> overwriten by eeepc-wmi later,
> if both of the modules will be loaded.
> Moreover, asus-nb-wmi should have the ability to access the
> asus_quirks defined in eeepc-wmi,
> so, the better way to do this is the detect_quirks function pointer
> should point to the same function
> in the eeepc-wmi.
> Do you have any good idea of this?

I think since I can test on both platforms and this should be done
ASAP, I should try to write the patch instead, I'll CC you when done.



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux