Re: [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Carios, 

於 一,2012-01-09 於 08:01 +0000,Carlos Corbacho 提到:
> On Monday 09 Jan 2012 14:31:17 Lee, Chun-Yi wrote:
> > From: "Lee, Chun-Yi" <jlee@xxxxxxxx>
> > 
> > Have many non-acer machines have AMW0_GUID2 method in DSDT, in
> > original acer-wmi design, driver direct set ACER_CAP_WIRELESS flag
> > for those machines but didn't check the functionality for set/get
> > wireless state.
> > It causes acer-wmi driver create a broken wireless rfkill and it
> > already set to soft blocked.
> > 
> > So, this patch add a wireless capability check before we set
> > ACER_CAP_WIRELESS flag to the machines that were included AMW0_GUID2.
> > It avoid acer-wmi create a broken wireless rfkill.
> > 
> > Thank's for Matthew Garrett give the idea.
> > 
> > Reference: brc#674353
> >         https://bugzilla.redhat.com/show_bug.cgi?id=674353
> > 
> > Tested on Lenovo E520.
> > Tested on Acer TravelMate 4750.
> 
> Is there really no other way to detect the availability of wireless on 
> hardware with that GUID without resorting to poking stuff to see if it sticks?
> 
> My assumption has always been that there must be of finding out, but I've never 
> had the hardware to check that with.
> 
> -Carlos
> 
> 

I just checked and found I also have no AMW0_GUID2 machines on my hand,
now.
I have some questions about AMW0_GUID2:

  + Why we enabled wireless capability in acer-wim if a non-acer machine has AMW0_GUID2 ?

  + I saw there have some magic number when you access AMW0_GUID1 (e.g. 0x9610, eax, ebx, ecx)
    Could you please kindly teach me how can grab those value for AMW0_GUID2?
    Does there have any useful dump or report log can provide by hardware owner?


Thanks a lot!
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux