Compile warning

["Stoyan Gaydarov" <stoyboyker@xxxxxxxxx>]

I saw this while compiling the -rc3 kernel:

  LD      drivers/char/hw_random/built-in.o
  CC      drivers/char/ip2/ip2base.o
  CC      drivers/char/ip2/ip2main.o
drivers/char/ip2/i2ellis.c:100: warning: 'iiEllisCleanup' defined but not used
drivers/char/ip2/ip2main.c:3178: warning: 'ip2main_pci_tbl' defined but not used
  LD      drivers/char/ip2/ip2.o
  LD      drivers/char/ip2/built-in.o


I looked into it and it seems that in i2ellis.c:100 we have:

static void
iiEllisCleanup(void)
{
}

The strange thing is that that file gets included by drivers/char/ip2/ip2main.c
which does call it on line 431:

        /* Cleanup the iiEllis subsystem. */
        iiEllisCleanup();

But this call is inside:

#ifdef MODULE
void __exit
ip2_cleanup_module(void)
{
.....
}
#endif /* MODULE */

So when it is not compiled as a module (in this case it wasn't) the
function it includes is not needed or used. What would be the proper
way to fix this warning? The other warning about 'ip2main_pci_tbl' is
a little more complicated so I will ignore it for now but this one
still seems like it could be an easy fix.

-- 

-Stoyan

--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ