Re: POM Xtables???

Patrick McHardy <kaber@xxxxxxxxx> · Tue, 01 Jul 2008 13:43:33 +0200

Jan Engelhardt wrote:

On Tuesday 2008-07-01 11:46, Patrick McHardy wrote:

Jozsef Kadlecsik wrote:

On Mon, 30 Jun 2008, Patrick McHardy wrote:

- LOGMARK - haven't seen it or can't remember

It adds the possibility to log the mark values of the packet/corresponding

conntrack entry via syslog. 

The feature should simply be added to the LOG target, there's no real point

to keep a separated target, as far as I see.

I agree. In fact I already added this to ipt_LOG/ip6t_LOG in
2.6.26-rc :)

You only added the nfmark, and it is printed unconditionally at that,
the latter of which I do not see as thrilling. Seems like it is time
for a new revision? Also I think the two modules should be unified
first.

It doesn't need a new revision, it doesn't affect the userspace
API in any way. As for the argument of parsers that might not
handle this: any parser needs to expect new things to be added
at the end of the line, otherwise its giving us no possibility
of ever extending the output, which is not reasonable.

--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html