Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin

[Javier Herrero <jherrero@xxxxxxxxxxxxx>]

Hi, Bryan,

So it seems that we must correct that in other place?

Regards,

Javier

Ben Dooks escribió:
> On Mon, Oct 13, 2008 at 05:10:09PM +0800, Bryan Wu wrote:
> > From: Javier Herrero <jherrero@xxxxxxxxxxxxx>
>
> No, your arch definitions of writesb and co are wrong if they
> are not taking 'void __iomem *' arguments.
>  
> > Signed-off-by: Javier Herrero <jherrero@xxxxxxxxxxxxx>
> > Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> > ---
> >  drivers/net/dm9000.c |   12 ++++++------
> >  1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> > index f42c23f..c4737ca 100644
> > --- a/drivers/net/dm9000.c
> > +++ b/drivers/net/dm9000.c
> > @@ -188,35 +188,35 @@ iow(board_info_t * db, int reg, int value)
> >  
> >  static void dm9000_outblk_8bit(void __iomem *reg, void *data, int count)
> >  {
> > -	writesb(reg, data, count);
> > +	writesb((int)reg, data, count);
> >  }
> >  
> >  static void dm9000_outblk_16bit(void __iomem *reg, void *data, int count)
> >  {
> > -	writesw(reg, data, (count+1) >> 1);
> > +	writesw((int)reg, data, (count+1) >> 1);
> >  }
> >  
> >  static void dm9000_outblk_32bit(void __iomem *reg, void *data, int count)
> >  {
> > -	writesl(reg, data, (count+3) >> 2);
> > +	writesl((int)reg, data, (count+3) >> 2);
> >  }
> >  
> >  /* input block from chip to memory */
> >  
> >  static void dm9000_inblk_8bit(void __iomem *reg, void *data, int count)
> >  {
> > -	readsb(reg, data, count);
> > +	readsb((int)reg, data, count);
> >  }
> >  
> >  
> >  static void dm9000_inblk_16bit(void __iomem *reg, void *data, int count)
> >  {
> > -	readsw(reg, data, (count+1) >> 1);
> > +	readsw((int)reg, data, (count+1) >> 1);
> >  }
> >  
> >  static void dm9000_inblk_32bit(void __iomem *reg, void *data, int count)
> >  {
> > -	readsl(reg, data, (count+3) >> 2);
> > +	readsl((int)reg, data, (count+3) >> 2);
> >  }
> >  
> >  /* dump block from chip to null */
> > --
> > 1.5.6

--
------------------------------------------------------------------------
Javier Herrero                            EMAIL: jherrero@xxxxxxxxxxxxxx
HV Sistemas S.L.                          PHONE:         +34 949 336 806
Los Charcones, 17A                        FAX:           +34 949 336 792
19170 El Casar - Guadalajara - Spain      WEB: http://www.hvsistemas.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html