Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure

[David Miller <davem@xxxxxxxxxxxxx>]

From: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>
Date: Mon, 13 Oct 2008 00:06:15 -0600

> QLGE driver only supports 4k, 8k, and 64k pages.
> Default page size on ia64 is 16k. Compile fails with:
> drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function)
> 
> Patch below makes the cause of the compile failure obvious.
> (Better would be to support 16k pages but I don't have the HW or interest.)
> 
> Signed-off-by: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>

I would rather, at this point, give the qlge guys a day or two to
try and add support for other page sizes if that is possible.

If it isn't possible, I'd rather see a Kconfig guard, a compile
failure is really not acceptable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html