Re: [patch 4/4] mISDN: misc timerdev fixes

[Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>]

> On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> 
> The bogus version which removes ->llseek just got into Linus' tree..

Well I still have this queued:

From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
Cc: Karsten Keil <kkeil@xxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/isdn/mISDN/timerdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix drivers/isdn/mISDN/timerdev.c
--- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix
+++ a/drivers/isdn/mISDN/timerdev.c
@@ -61,7 +61,7 @@ mISDN_open(struct inode *ino, struct fil
 	init_waitqueue_head(&dev->wait);
 	filep->private_data = dev;
 	__module_get(THIS_MODULE);
-	return 0;
+	return nonseekable_open(ino, filep);
 }
 
 static int
_


So presumably whoever merged the unfixed version flubbed the fix.

If that'll fix it.  Is it sufficient?  I think so.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html