|
|
|
Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > On Sun, 12 Oct 2008 08:40:39 -0500 > "Steve French" <smfrench@xxxxxxxxx> wrote: > >> Rafael and Guo-Fu, >> The following change to address the compile error that you noted is >> slightly different than what you suggested but should fix what you >> found. >> > > Actually, I like Adrian/Rafael's fix better. I think we should avoid > cluttering up the code with #ifdef's where possible. key_put() already > is a no-op when CONFIG_KEYS is disabled. We might as well do the same > thing with key_revoke(). I don't think it matters much - but we probably shouldn't be overriding global functions. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
[Kernel List] [Site Home] [Ethernet Bridging] [Git] [IETF Annouce] [Linux Assembly] [VLAN] [Networking] [Security] [Bugtraq] [Rubini] [Photo] [Singles Social Netowrking] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Virtualization] [Linux Security] [Linux IDE] [Linux RAID] [Linux SCSI] [Linux Wireless] [DDR & Rambus] [Free Dating] [Linux Resources] [Wireless Reading Device]
|
|