Re: [PATCH 3/3] Phonet: declare headers

["Rémi Denis-Courmont" <remi.denis-courmont@xxxxxxxxx>]

On Tuesday 30 September 2008 12:59:57 ext David Miller, you wrote:
> From: Remi Denis-Courmont <remi.denis-courmont@xxxxxxxxx>
> Date: Wed, 24 Sep 2008 19:11:40 +0300
>
> > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@xxxxxxxxx>
>
> Applied.
>
> I took a look and noticed that if_phonet.h needs some top-level
> ifdef multiple inclusion protection.

Oops. Patch follows.

While we're on if_phonet.h, I also wonder what the "right" place for 
phonet_header_ops is... Currently in phonet.ko, any network device driver 
link-depends on the socket stack :-( for two tiny little header_ops 
callbacks. Is that OK? or should it go to core like the Ethernet ops, or be 
inline'd?

Regards,

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html