Re: /proc/net/igmp group address encoding

[David Stevens <dlstevens@xxxxxxxxxx>]

netdev-owner@xxxxxxxxxxxxxxx wrote on 09/24/2008 11:44:45 PM:

> Hi,
> 
> - I had noticed a long ago that the IP addresses under
>  /proc/net/igmp are in Hexa format. I am preparing a patch to fix it
> and it will be send very soon.

I don't think we can do that, since I believe netstat expects
to see this the way it is. Maybe if we change netstat to support
both and wait a year for all distros to get it... :-)


> So indeed , the count (mc_count of netdevice) shows both IPv4 and IPv6 
igmp
> groups, but in current implementation it is not immediate
> to change it. Currently, net_device struct does not have specific
> fields for ipv4 or ipv6.  One way of preparing a patch
> is to change net_device to have mc_count4 and mc_count6;
> I am really willing to prepare such a patch, but I am not sure such a
> change in net_device is a proper and a justified
> change to do.

        These belong with mc_list in inet6_dev and in_device. Really,
I'd just add "mc_count" as a field right next to mc_list and inc/dec
it when calling the group join/leave functions-- use the list lock
to protect it. The structure it's in distinguishes the protocol,
and the names are otherwise common.

                                                                +-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html