Re: [PATCH] tcp: fix tcp header size miscalculation when window scale is unused

[David Miller <davem@xxxxxxxxxxxxx>]

From: "Adam Langley" <agl@xxxxxxxxxxxxxxxxxx>
Date: Sun, 24 Aug 2008 10:40:23 -0700

> From: Philip Love <love_phil@xxxxxxx>
> 
> tcp: fix tcp header size miscalculation when window scale is unused
> 
> The size of the TCP header is miscalculated when the window scale ends up being
> 0. Additionally, this can be induced by sending a SYN to a passive open port
> with a window scale option with value 0.
> 
> Signed-off-by: Philip Love <love_phil@xxxxxxx>
> Signed-off-by: Adam Langley <agl@xxxxxxxxxxxxxxxxxx>

Adam I really appreciate you're fixing up the patch for Philip, but
how in the world is he ever going to learn how to submit a patch
properly if you just do it for him?

I could have fixed it up too, but I pushed it back so that he learns
how to submit a patch correctly, and this will help him and the rest
of us in the future when he wants to submit other patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html