Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

[David Miller <davem@xxxxxxxxxxxxx>]

From: Jeff Garzik <jeff@xxxxxxxxxx>
Date: Fri, 22 Aug 2008 05:22:17 -0400

> - The kmap use is interesting

It's so much easier to just always tack on the pages or whatever
and use __pskb_pull_tail(skb, SOME_MIN_HEADER_LENGTH)

I also notice that this driver does not do:

	skb_reserve(skb, NET_IP_ALIGN);

on RX packets to get the IP headers properly 4-byte aligned aligned
after the ethernet header.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html