Re: [PATCH 1/1] r8169: balance pci_map / pci_unmap pair

[Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>]

On Thu, 21 Aug 2008 23:47:34 +0200
Francois Romieu <romieu@xxxxxxxxxxxxx> wrote:

> The leak hurts with swiotlb and jumbo frames (see
> http://bugzilla.kernel.org/show_bug.cgi?id=9468).
> 
> Heavily hinted by Ilpo J__rvinen <ilpo.jarvinen@xxxxxxxxxxx>.
> 
> Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
> Tested-by: Alistair John Strachan <alistair@xxxxxxxxxxxxx>
> Tested-by: Timothy J Fontaine <tjfontaine@xxxxxxxxxxxxxxxxx>
> Cc: Edward Hsu <edward_hsu@xxxxxxxxxxxxxx>
> ---
>  drivers/net/r8169.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index a3e3895..0f6f974 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -2792,7 +2792,7 @@ static int rtl8169_rx_interrupt(struct net_device *dev,
>  					pkt_size, PCI_DMA_FROMDEVICE);
>  				rtl8169_mark_to_asic(desc, tp->rx_buf_sz);
>  			} else {
> -				pci_unmap_single(pdev, addr, pkt_size,
> +				pci_unmap_single(pdev, addr, tp->rx_buf_sz,
>  						 PCI_DMA_FROMDEVICE);
>  				tp->Rx_skbuff[entry] = NULL;
>  			}

Also needed in 2.6.25.x and 2.6.26.x, yes?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html