Re: 2.6.27-rc4: icmp_sk() uses smp_processor_id() in preemptible code

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

adobriyan@xxxxxxxxx wrote:
> Steps to reproduce:
> 
>        CONFIG_PREEMPT=y
>        CONFIG_DEBUG_PREEMPT=y
>        tracepath <something>
> 
> icmp6_sk() is similar (I haven't checked at runtime, though).
> 
> BUG: using smp_processor_id() in preemptible [00000000] code: tracepath/3205
> caller is icmp_sk+0x15/0x30
> Pid: 3205, comm: tracepath Not tainted 2.6.27-rc4 #1
> 
> Call Trace:
> [<ffffffff8031af14>] debug_smp_processor_id+0xe4/0xf0
> [<ffffffff80409405>] icmp_sk+0x15/0x30
> [<ffffffff8040a17b>] icmp_send+0x4b/0x3f0

Caused by:

commit 405666db84b984b68fc75794069f424c02e5796c
Author: Denis V. Lunev <den@xxxxxxxxxx>
Date:   Fri Feb 29 11:16:46 2008 -0800

    [ICMP]: Pass proper ICMP socket into icmp(v6)_xmit_(un)lock.

We need to disable preemption (was provided by disabling BH) before
getting the per-cpu ICMP socket.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html