Re: [PATCH net-next 3/9] ipv4: remove static flush_delay variable

[David Miller <davem@xxxxxxxxxxxxx>]

From: "Denis V. Lunev" <den@xxxxxxxxxx>
Date: Mon, 07 Jul 2008 15:26:14 +0400

> On Mon, 2008-07-07 at 01:43 -0700, Eric W. Biederman wrote:
> > "Denis V. Lunev" <den@xxxxxxxxxx> writes:
> > 
> > > flush delay is used as an external storage for net.ipv4.route.flush sysctl
> > > entry. It is write-only.
> > >
> > > The ctl_table->data for this entry is used once. Fix this case to point
> > > to the stack to remove global variable. Do this to avoid additional
> > > variable on struct net in the next patch.
> > >
> > > Possible race (as it was before) accessing this local variable is removed
> > > using flush_mutex.
> > 
> > FYI.  You can avoid the locking entirely by defining a local struct ctl_table variable
> > on the stack.
> 
> Dave, could you consider the patch attached?

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html