Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled

[James Morris <jmorris@xxxxxxxxx>]

On Sat, 31 May 2008, Adam Langley wrote:

> When MD5 signatures are turned on we can end up with syntactically invalid
> packets with a header length < 20 bytes. This is because tcp_header_size
> overflows with 12 bytes of timestamp, 20 bytes of signature and > 8 bytes of
> SACK option.
> 
> Since we can't fit any SACK blocks in the final 8 bytes of options space, and
> the MD5 signature is more important, we disable including SACK, or even
> advertising it, when MD5 is enabled.
> 
> Signed-off-by: Adam Langley <agl@xxxxxxxxxxxxxxxxxx>

Reviewed-by: James Morris <jmorris@xxxxxxxxx>


(FYI, the upcoming replacement for this, TCP-AO, is designed to be SACK 
compatible)


-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html