Re: [UDP6]: Restore sk_filter optimisation

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20071029153320.d2c00f62.mitch@xxxxxxxxxxxxxxxxxx> (at Mon, 29 Oct 2007 15:33:20 +0900), Mitsuru Chinen <mitch@xxxxxxxxxxxxxxxxxx> says:

> Hello Herbert,
> 
> Let me ask a question about this patch.
> After this patch was applied, 2 of the protocol stack behaviors were
> changed when it receives a UDP datagram with broken checksum:
> 
>  1. udp6InDatagrams is incremented instead of udpInErrors
>  2. In userland, recvfrom() replies an error with EAGAIN.
>     recvfrom() wasn't aware of such a packet before.
> 
> Are these changes intentional?

And, we're not sure how much the "optimization"'s benefit is.
It is even worse when we are handling multicast packets.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html