Re: [PATCH net] ipv4: add a sock pointer to ip_queue_xmit() and friends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-04-15 at 13:16 -0400, David Miller wrote:

> This doesn't compile, I'd expect to see hunks such as:
> 
> @@ -184,7 +184,7 @@ void *dst_alloc(struct dst_ops *ops, struct net_device *dev,
>  	dst->xfrm = NULL;
>  #endif
>  	dst->input = dst_discard;
> -	dst->output = dst_discard;
> +	dst->output = dst_discard_sk;
>  	dst->error = 0;
>  	dst->obsolete = initial_obsolete;
>  	dst->header_len = 0;
> 
> for this file, but I don't.  Maybe you posted an outdated revision of your
> patch?  There also aren't the necessary decnet and XFRM changes, layers
> which also use dst->output().
> 
> Anyways, I'm splitting up your patches and sorting this out.

Hmmpff. The truth is I did a "make allyesconfig;make -j24", and the
build completed, but I missed warnings.

And the thing even booted and ran properly.

Sorry for this, and thanks for taking care of the mess.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]