Re: [PATCH net] netlink: preserve netlink pkt_type on dev_queue_xmit_nit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/12/2014 11:02 PM, David Miller wrote:
...
I really don't like the idea of treating some packets that go out of
dev_queue_xmit_nit() as one type, and others of another type.

Understood and agreed, fwiw, I was fighting with myself and don't really
like it either.

Because dammit, if the packet is going through this function it very
much is PACKET_OUTGOING.

It's outgoing to your special netlink tap device in this case right?

Yep; it's of course still outgoing, just tells more specific if it has
been sent from user space or kernel space, thus it preserves PACKET_USER
and PACKET_KERNEL (as otherwise overwritten -- it's for user space to
tell from which direction the skb has been sent). I'll think about it
further and already have some other ideas to try out that are hopefully
more generic/acceptable. Anyway, thanks for your feedback.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]