RE: [PATCH 01/54] uml/net_kern: Call dev_consume_skb_any instead of dev_kfree_skb.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Of Eric W. Biederman
...
> I really don't think using enum skb_free_reason makes any sense
> whatsoever.  Not in the implementation of dev_kfree_skb_any and
> dev_kfree_skb_irq and certainly not in a driver.  What
> net/core/drop_monitor.c wants is the address of the function where drops
> occur (so we can track down and debug why the kernel is dropping
> packets) and the existing implementation of dev_kfree_skb_any and
> dev_kfree_skb_irq loose that information.  The use of enum
> skb_free_reason is a big part of the reason why we loose that
> information.  (We should be using a (void *) so that we can capture
> __builtin_return_address(0) instead...

Maybe more useful to allow a literal string be given.
Easier to find in the source tree than the return address.

Or (OTT) create a linkset data item containing info about the
call site and a counter....

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Discussion]     [TCP Instrumentation]     [Ethernet Bridging]     [Linux Wireless Networking]     [Linux WPAN Networking]     [Linux Host AP]     [Linux WPAN Networking]     [Linux Bluetooth Networking]     [Linux ATH6KL Networking]     [Linux Networking Users]     [Linux Coverity]     [VLAN]     [Git]     [IETF Annouce]     [Linux Assembly]     [Security]     [Bugtraq]     [Yosemite Information]     [MIPS Linux]     [ARM Linux Kernel]     [ARM Linux]     [Linux Virtualization]     [Linux IDE]     [Linux RAID]     [Linux SCSI]